Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: extensions/browser/api/vpn_provider/vpn_provider_api.h

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_VPN_PROVIDER_VPN_PROVIDER_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_VPN_PROVIDER_VPN_PROVIDER_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_VPN_PROVIDER_VPN_PROVIDER_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_VPN_PROVIDER_VPN_PROVIDER_API_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/browser/extension_function.h" 10 #include "extensions/browser/extension_function.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 class VpnThreadExtensionFunction : public UIThreadExtensionFunction { 14 class VpnThreadExtensionFunction : public UIThreadExtensionFunction {
15 public: 15 public:
16 void SignalCallCompletionSuccess(); 16 void SignalCallCompletionSuccess();
17 void SignalCallCompletionSuccessWithId(const std::string& configuration_id); 17 void SignalCallCompletionSuccessWithId(const std::string& configuration_id);
18 void SignalCallCompletionSuccessWithWarning(const std::string& warning);
18 19
19 void SignalCallCompletionFailure(const std::string& error_name, 20 void SignalCallCompletionFailure(const std::string& error_name,
20 const std::string& error_message); 21 const std::string& error_message);
21 22
22 protected: 23 protected:
23 ~VpnThreadExtensionFunction() override; 24 ~VpnThreadExtensionFunction() override;
24 }; 25 };
25 26
26 class VpnProviderCreateConfigFunction : public VpnThreadExtensionFunction { 27 class VpnProviderCreateConfigFunction : public VpnThreadExtensionFunction {
27 public: 28 public:
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 75
75 protected: 76 protected:
76 ~VpnProviderNotifyConnectionStateChangedFunction() override; 77 ~VpnProviderNotifyConnectionStateChangedFunction() override;
77 78
78 ExtensionFunction::ResponseAction Run() override; 79 ExtensionFunction::ResponseAction Run() override;
79 }; 80 };
80 81
81 } // namespace extensions 82 } // namespace extensions
82 83
83 #endif // CHROME_BROWSER_EXTENSIONS_API_VPN_PROVIDER_VPN_PROVIDER_API_H_ 84 #endif // CHROME_BROWSER_EXTENSIONS_API_VPN_PROVIDER_VPN_PROVIDER_API_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698