chromeos/dbus/shill_third_party_vpn_driver_client.h - Issue 1014053002: Provide warning message for setParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_third_party_vpn_driver_client.h

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_third_party_vpn_driver_client.h

diff --git a/chromeos/dbus/shill_third_party_vpn_driver_client.h b/chromeos/dbus/shill_third_party_vpn_driver_client.h

index ac4738c3b3183bc08d6d72b388c980317dc9fba6..d75fab9260fd6e3225671c29c222a31dea70b5ab 100644

--- a/chromeos/dbus/shill_third_party_vpn_driver_client.h

+++ b/chromeos/dbus/shill_third_party_vpn_driver_client.h

@@ -56,7 +56,7 @@ class CHROMEOS_EXPORT ShillThirdPartyVpnDriverClient : public DBusClient {

virtual void SetParameters(

const std::string& object_path_value,

const base::DictionaryValue& parameters,

- const base::Closure& callback,

+ const ShillClientHelper::StringCallback& callback,

const ShillClientHelper::ErrorCallback& error_callback) = 0;

// Calls UpdateConnectionState method.