Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chromeos/dbus/shill_third_party_vpn_driver_client.h

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_
6 #define CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_ 6 #define CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // Removes an |observer| for the third party vpn driver at 49 // Removes an |observer| for the third party vpn driver at
50 // |object_path_value|. 50 // |object_path_value|.
51 virtual void RemoveShillThirdPartyVpnObserver( 51 virtual void RemoveShillThirdPartyVpnObserver(
52 const std::string& object_path_value) = 0; 52 const std::string& object_path_value) = 0;
53 53
54 // Calls SetParameters method. 54 // Calls SetParameters method.
55 // |callback| is called after the method call succeeds. 55 // |callback| is called after the method call succeeds.
56 virtual void SetParameters( 56 virtual void SetParameters(
57 const std::string& object_path_value, 57 const std::string& object_path_value,
58 const base::DictionaryValue& parameters, 58 const base::DictionaryValue& parameters,
59 const base::Closure& callback, 59 const ShillClientHelper::StringCallback& callback,
60 const ShillClientHelper::ErrorCallback& error_callback) = 0; 60 const ShillClientHelper::ErrorCallback& error_callback) = 0;
61 61
62 // Calls UpdateConnectionState method. 62 // Calls UpdateConnectionState method.
63 // |callback| is called after the method call succeeds. 63 // |callback| is called after the method call succeeds.
64 virtual void UpdateConnectionState( 64 virtual void UpdateConnectionState(
65 const std::string& object_path_value, 65 const std::string& object_path_value,
66 const uint32_t connection_state, 66 const uint32_t connection_state,
67 const base::Closure& callback, 67 const base::Closure& callback,
68 const ShillClientHelper::ErrorCallback& error_callback) = 0; 68 const ShillClientHelper::ErrorCallback& error_callback) = 0;
69 69
(...skipping 14 matching lines...) Expand all
84 // Create() should be used instead. 84 // Create() should be used instead.
85 ShillThirdPartyVpnDriverClient(); 85 ShillThirdPartyVpnDriverClient();
86 86
87 private: 87 private:
88 DISALLOW_COPY_AND_ASSIGN(ShillThirdPartyVpnDriverClient); 88 DISALLOW_COPY_AND_ASSIGN(ShillThirdPartyVpnDriverClient);
89 }; 89 };
90 90
91 } // namespace chromeos 91 } // namespace chromeos
92 92
93 #endif // CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_ 93 #endif // CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698