Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chromeos/dbus/shill_third_party_vpn_driver_client.cc

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_third_party_vpn_driver_client.cc
diff --git a/chromeos/dbus/shill_third_party_vpn_driver_client.cc b/chromeos/dbus/shill_third_party_vpn_driver_client.cc
index a1a761c52b8bd528216a07ecb55bc738fce9c1e9..7a2832516a85ee914ff64141a0efd2f4306ee683 100644
--- a/chromeos/dbus/shill_third_party_vpn_driver_client.cc
+++ b/chromeos/dbus/shill_third_party_vpn_driver_client.cc
@@ -44,7 +44,7 @@ class ShillThirdPartyVpnDriverClientImpl
void SetParameters(
const std::string& object_path_value,
const base::DictionaryValue& parameters,
- const base::Closure& callback,
+ const ShillClientHelper::StringCallback& callback,
const ShillClientHelper::ErrorCallback& error_callback) override;
void UpdateConnectionState(
@@ -200,7 +200,7 @@ void ShillThirdPartyVpnDriverClientImpl::DeleteHelper(
void ShillThirdPartyVpnDriverClientImpl::SetParameters(
const std::string& object_path_value,
const base::DictionaryValue& parameters,
- const base::Closure& callback,
+ const ShillClientHelper::StringCallback& callback,
const ShillClientHelper::ErrorCallback& error_callback) {
dbus::MethodCall method_call(shill::kFlimflamThirdPartyVpnInterface,
shill::kSetParametersFunction);
@@ -226,7 +226,8 @@ void ShillThirdPartyVpnDriverClientImpl::SetParameters(
}
writer.CloseContainer(&array_writer);
GetHelper(object_path_value)
- ->CallVoidMethodWithErrorCallback(&method_call, callback, error_callback);
+ ->CallStringMethodWithErrorCallback(&method_call, callback,
+ error_callback);
}
void ShillThirdPartyVpnDriverClientImpl::UpdateConnectionState(

Powered by Google App Engine
This is Rietveld 408576698