Provide warning message for setParameters

chromeos/dbus/shill_third_party_vpn_driver_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/shill_third_party_vpn_driver_client.h"
 
 #include "base/bind.h"
 #include "base/stl_util.h"
 #include "chromeos/dbus/shill_third_party_vpn_observer.h"
 #include "dbus/bus.h"
@@ skipping 26 matching lines @@
   void AddShillThirdPartyVpnObserver(
       const std::string& object_path_value,
       ShillThirdPartyVpnObserver* observer) override;
 
   void RemoveShillThirdPartyVpnObserver(
       const std::string& object_path_value) override;
 
   void SetParameters(
       const std::string& object_path_value,
       const base::DictionaryValue& parameters,
-      const base::Closure& callback,
+      const ShillClientHelper::StringCallback& callback,
       const ShillClientHelper::ErrorCallback& error_callback) override;
 
   void UpdateConnectionState(
       const std::string& object_path_value,
       const uint32_t connection_state,
       const base::Closure& callback,
       const ShillClientHelper::ErrorCallback& error_callback) override;
 
   void SendPacket(
       const std::string& object_path_value,
@@ skipping 135 matching lines @@
 
   bus_->RemoveObjectProxy(shill::kFlimflamServiceName, object_path,
                           base::Bind(&base::DoNothing));
   helpers_.erase(helpers_.find(object_path.value()));
   delete helper_info;
 }
 
 void ShillThirdPartyVpnDriverClientImpl::SetParameters(
     const std::string& object_path_value,
     const base::DictionaryValue& parameters,
-    const base::Closure& callback,
+    const ShillClientHelper::StringCallback& callback,
     const ShillClientHelper::ErrorCallback& error_callback) {
   dbus::MethodCall method_call(shill::kFlimflamThirdPartyVpnInterface,
                                shill::kSetParametersFunction);
   dbus::MessageWriter writer(&method_call);
   dbus::MessageWriter array_writer(nullptr);
   writer.OpenArray("{ss}", &array_writer);
   for (base::DictionaryValue::Iterator it(parameters); !it.IsAtEnd();
        it.Advance()) {
     if (valid_keys_.find(it.key()) == valid_keys_.end()) {
       LOG(WARNING) << "Unknown key " << it.key();
       continue;
     }
     std::string value;
     if (!it.value().GetAsString(&value)) {
       LOG(WARNING) << "Non string value " << it.value();
       continue;
     }
     dbus::MessageWriter entry_writer(nullptr);
     array_writer.OpenDictEntry(&entry_writer);
     entry_writer.AppendString(it.key());
     entry_writer.AppendString(value);
     array_writer.CloseContainer(&entry_writer);
   }
   writer.CloseContainer(&array_writer);
   GetHelper(object_path_value)
-      ->CallVoidMethodWithErrorCallback(&method_call, callback, error_callback);
+      ->CallStringMethodWithErrorCallback(&method_call, callback,
+                                          error_callback);
 }
 
 void ShillThirdPartyVpnDriverClientImpl::UpdateConnectionState(
     const std::string& object_path_value,
     const uint32_t connection_state,
     const base::Closure& callback,
     const ShillClientHelper::ErrorCallback& error_callback) {
   dbus::MethodCall method_call(shill::kFlimflamThirdPartyVpnInterface,
                                shill::kUpdateConnectionStateFunction);
   dbus::MessageWriter writer(&method_call);
@@ skipping 92 matching lines @@
 
 ShillThirdPartyVpnDriverClient::~ShillThirdPartyVpnDriverClient() {
 }
 
 // static
 ShillThirdPartyVpnDriverClient* ShillThirdPartyVpnDriverClient::Create() {
   return new ShillThirdPartyVpnDriverClientImpl();
 }
 
 }  // namespace chromeos