Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1012583002: CC Animations: Port UI Browser Compositor to use compositor animation timelines. (Closed)

Created:
5 years, 9 months ago by loyso (OOO)
Modified:
5 years ago
Reviewers:
Ian Vollick, ajuma, piman
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@redirect
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Port UI Browser Compositor to use compositor animation timelines. Use AnimationPlayer to add animations if new system enabled. Previous episode: https://codereview.chromium.org/1009233002/ Next episode: https://codereview.chromium.org/1119763003/ A step towards AnimationPlayer/AnimationTimeline decoupling. BUG=394777 R=ajuma@chromium.org R=vollick@chromium.org

Patch Set 1 #

Patch Set 2 : Refactor Layer attachment. #

Patch Set 3 : Rearrange changes across episodes. #

Patch Set 4 : #

Patch Set 5 : Use AnimationHost. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -12 lines) Patch
M ui/compositor/compositor.h View 1 2 3 4 5 4 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 5 5 chunks +21 lines, -0 lines 0 comments Download
M ui/compositor/layer.h View 1 2 3 4 5 3 chunks +9 lines, -0 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 3 4 5 11 chunks +103 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
loyso (OOO)
5 years, 9 months ago (2015-03-24 02:25:27 UTC) #1
loyso (OOO)
PTAL! Alternatively, we could create ui::Layer::animation_player_ only if it's needed (on animation addition). What do ...
5 years ago (2015-12-03 06:16:36 UTC) #4
Ian Vollick
On 2015/12/03 06:16:36, loyso wrote: > PTAL! > Alternatively, we could create ui::Layer::animation_player_ only if ...
5 years ago (2015-12-09 18:57:01 UTC) #5
loyso (OOO)
5 years ago (2015-12-17 05:21:59 UTC) #6 
On 2015/12/09 18:57:01, vollick wrote:
> Creating it lazily does seem like a good idea if it's not too much trouble.
I've designed a better designed solution where AnimationPlayer lives in
LayerAnimator (2 dependent CLs)
Review, please! This is the only compositor which blocks us from deleteting the
old system.

https://codereview.chromium.org/1531913003
https://codereview.chromium.org/1533643003

Powered by Google App Engine
This is Rietveld 408576698