Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 1531913003: CC Animations: Make ui::LayerAnimator a LayerAnimationEventObserver (instead of ui::Layer) (Closed)

Created:
5 years ago by loyso (OOO)
Modified:
5 years ago
Reviewers:
Ian Vollick, ajuma, piman
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Make ui::LayerAnimator a LayerAnimationEventObserver (instead of ui::Layer) This will allow us to move more animation code out of ui::Layer. BUG=394777 Committed: https://crrev.com/1fbd9f9597d87b9dd29aecc87879538b168b06e4 Cr-Commit-Position: refs/heads/master@{#365774}

Patch Set 1 #

Patch Set 2 : Fix LayerAnimator::SetDelegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M ui/compositor/layer.h View 4 chunks +2 lines, -6 lines 0 comments Download
M ui/compositor/layer.cc View 7 chunks +5 lines, -9 lines 0 comments Download
M ui/compositor/layer_animation_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/layer_animator.h View 5 chunks +15 lines, -2 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.cc View 4 chunks +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
loyso (OOO)
vollick@chromium.org: Please review changes in ajuma@chromium.org: Please review changes in piman@chromium.org: Please review changes in
5 years ago (2015-12-17 05:22:37 UTC) #2
piman
lgtm
5 years ago (2015-12-17 05:29:04 UTC) #3
Ian Vollick
On 2015/12/17 05:29:04, piman (in KST timezone) wrote: > lgtm This lgtm, too.
5 years ago (2015-12-17 05:49:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531913003/20001
5 years ago (2015-12-17 06:42:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 07:43:19 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 07:44:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fbd9f9597d87b9dd29aecc87879538b168b06e4
Cr-Commit-Position: refs/heads/master@{#365774}

Powered by Google App Engine
This is Rietveld 408576698