Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011503004: Autofill card unmasking - never store locally in incognito (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill card unmasking - never store locally in incognito BUG=469780 Committed: https://crrev.com/1baedb1145f054169cc980be347755dcc65fe057 Cr-Commit-Position: refs/heads/master@{#321887}

Patch Set 1 #

Total comments: 2

Patch Set 2 : inline and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -26 lines) Patch
M chrome/browser/ui/autofill/card_unmask_prompt_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc View 1 7 chunks +31 lines, -22 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc View 1 4 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Evan Stade
+rouslan for review +walter for metrics
5 years, 9 months ago (2015-03-23 19:12:50 UTC) #2
Walter Cacau
LGTM for metrics
5 years, 9 months ago (2015-03-23 19:38:05 UTC) #3
please use gerrit instead
lgtm https://codereview.chromium.org/1011503004/diff/1/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc File chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc (right): https://codereview.chromium.org/1011503004/diff/1/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc#newcode219 chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc:219: return !profile->IsOffTheRecord(); nit: Technically, you can save 1 ...
5 years, 9 months ago (2015-03-23 19:57:58 UTC) #4
Evan Stade
5 years, 9 months ago (2015-03-23 21:49:42 UTC) #5
Evan Stade
https://codereview.chromium.org/1011503004/diff/1/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc File chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc (right): https://codereview.chromium.org/1011503004/diff/1/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc#newcode219 chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc:219: return !profile->IsOffTheRecord(); On 2015/03/23 19:57:58, Rouslan Solomakhin wrote: > ...
5 years, 9 months ago (2015-03-23 21:49:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011503004/20001
5 years, 9 months ago (2015-03-23 21:50:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 22:59:39 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 23:00:41 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1baedb1145f054169cc980be347755dcc65fe057
Cr-Commit-Position: refs/heads/master@{#321887}

Powered by Google App Engine
This is Rietveld 408576698