Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc

Issue 1011503004: Autofill card unmasking - never store locally in incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inline and format Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc b/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc
index 38643a5d53e01faf8752b64c8f09d9b0483d5ceb..70641f0290dee3d08494e8c19584f92517b3d4f9 100644
--- a/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc
+++ b/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl_unittest.cc
@@ -64,6 +64,7 @@ class TestCardUnmaskPromptController : public CardUnmaskPromptControllerImpl {
scoped_refptr<content::MessageLoopRunner> runner)
: CardUnmaskPromptControllerImpl(contents),
test_unmask_prompt_view_(test_unmask_prompt_view),
+ can_store_locally_(true),
runner_(runner),
weak_factory_(this) {}
@@ -71,6 +72,9 @@ class TestCardUnmaskPromptController : public CardUnmaskPromptControllerImpl {
return test_unmask_prompt_view_;
}
void LoadRiskFingerprint() override {}
+ bool CanStoreLocally() const override { return can_store_locally_; }
+
+ void set_can_store_locally(bool can) { can_store_locally_ = can; }
base::WeakPtr<TestCardUnmaskPromptController> GetWeakPtr() {
return weak_factory_.GetWeakPtr();
@@ -78,6 +82,7 @@ class TestCardUnmaskPromptController : public CardUnmaskPromptControllerImpl {
private:
TestCardUnmaskPromptView* test_unmask_prompt_view_;
+ bool can_store_locally_;
scoped_refptr<content::MessageLoopRunner> runner_;
base::WeakPtrFactory<TestCardUnmaskPromptController> weak_factory_;
@@ -296,6 +301,30 @@ TEST_F(CardUnmaskPromptControllerImplTest, LogDidNotOptOut) {
AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_OUT, 1);
}
+TEST_F(CardUnmaskPromptControllerImplTest, DontLogForHiddenCheckbox) {
+ controller()->set_can_store_locally(false);
+ controller()->ShowPrompt(CreateCard(), delegate()->GetWeakPtr());
+ base::HistogramTester histogram_tester;
+
+ controller()->OnUnmaskResponse(
+ base::ASCIIToUTF16("123"), base::ASCIIToUTF16("01"),
+ base::ASCIIToUTF16("2015"), false /* should_store_pan */);
+ controller()->OnUnmaskDialogClosed();
+
+ histogram_tester.ExpectBucketCount(
+ "Autofill.UnmaskPrompt.Events",
+ AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_OPT_IN, 0);
+ histogram_tester.ExpectBucketCount(
+ "Autofill.UnmaskPrompt.Events",
+ AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_IN, 0);
+ histogram_tester.ExpectBucketCount(
+ "Autofill.UnmaskPrompt.Events",
+ AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_OPT_OUT, 0);
+ histogram_tester.ExpectBucketCount(
+ "Autofill.UnmaskPrompt.Events",
+ AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_OUT, 0);
+}
+
TEST_F(CardUnmaskPromptControllerImplTest, LogRealPanResultSuccess) {
controller()->ShowPrompt(CreateCard(), delegate()->GetWeakPtr());
controller()->OnUnmaskResponse(base::ASCIIToUTF16("123"),
« no previous file with comments | « chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc ('k') | chrome/browser/ui/autofill/chrome_autofill_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698