Autofill card unmasking - never store locally in incognito

chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/autofill/risk_util.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace autofill {
@@ skipping 37 matching lines @@
     return false;
   }
   return true;
 }
 
 void CardUnmaskPromptControllerImpl::OnVerificationResult(
     AutofillClient::GetRealPanResult result) {
   if (!card_unmask_view_)
     return;
 
+  unmasking_result_ = result;
   base::string16 error_message;
-  unmasking_result_ = result;
   switch (result) {
     case AutofillClient::SUCCESS:
       break;
 
     case AutofillClient::TRY_AGAIN_FAILURE: {
       error_message = l10n_util::GetStringUTF16(
           IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_TRY_AGAIN);
       break;
     }
 
     case AutofillClient::PERMANENT_FAILURE: {
       error_message = l10n_util::GetStringUTF16(
           IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_PERMANENT);
       break;
     }
 
     case AutofillClient::NETWORK_ERROR: {
       error_message = l10n_util::GetStringUTF16(
           IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_NETWORK);
       break;
     }
   }
 
   AutofillMetrics::LogRealPanResult(result);
-  unmasking_allow_retry_ = AllowsRetry(result);
   card_unmask_view_->GotVerificationResult(error_message,
                                            AllowsRetry(result));
 }
 
 void CardUnmaskPromptControllerImpl::OnUnmaskDialogClosed() {
   card_unmask_view_ = nullptr;
   LogOnCloseEvents();
   delegate_->OnUnmaskPromptClosed();
 }
 
 void CardUnmaskPromptControllerImpl::LogOnCloseEvents() {
   if (unmasking_number_of_attempts_ == 0) {
     AutofillMetrics::LogUnmaskPromptEvent(
         AutofillMetrics::UNMASK_PROMPT_CLOSED_NO_ATTEMPTS);
     return;
   }
 
-  bool final_should_store_pan =
-      user_prefs::UserPrefs::Get(web_contents_->GetBrowserContext())
-          ->GetBoolean(prefs::kAutofillWalletImportStorageCheckboxState);
-
+  bool final_should_store_pan = pending_response_.should_store_pan;
   if (unmasking_result_ == AutofillClient::SUCCESS) {
     AutofillMetrics::LogUnmaskPromptEvent(
         unmasking_number_of_attempts_ == 1
         ? AutofillMetrics::UNMASK_PROMPT_UNMASKED_CARD_FIRST_ATTEMPT
         : AutofillMetrics::UNMASK_PROMPT_UNMASKED_CARD_AFTER_FAILED_ATTEMPTS);
     if (final_should_store_pan) {
       AutofillMetrics::LogUnmaskPromptEvent(
           AutofillMetrics::UNMASK_PROMPT_SAVED_CARD_LOCALLY);
     }
   } else {
     AutofillMetrics::LogUnmaskPromptEvent(
         AllowsRetry(unmasking_result_)
         ? AutofillMetrics
               ::UNMASK_PROMPT_CLOSED_FAILED_TO_UNMASK_RETRIABLE_FAILURE
         : AutofillMetrics
               ::UNMASK_PROMPT_CLOSED_FAILED_TO_UNMASK_NON_RETRIABLE_FAILURE);
   }
 
-  // Tracking changes in local save preference.
-  AutofillMetrics::UnmaskPromptEvent event;
-  if (unmasking_initial_should_store_pan_ && final_should_store_pan) {
-    event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_OUT;
-  } else if (!unmasking_initial_should_store_pan_
-             && !final_should_store_pan) {
-    event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_IN;
-  } else if (unmasking_initial_should_store_pan_
-             && !final_should_store_pan) {
-    event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_OPT_OUT;
-  } else {
-    event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_OPT_IN;
+  if (CanStoreLocally()) {
+    // Tracking changes in local save preference.
+    AutofillMetrics::UnmaskPromptEvent event;
+    if (unmasking_initial_should_store_pan_ && final_should_store_pan) {
+      event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_OUT;
+    } else if (!unmasking_initial_should_store_pan_
+               && !final_should_store_pan) {
+      event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_NOT_OPT_IN;
+    } else if (unmasking_initial_should_store_pan_
+               && !final_should_store_pan) {
+      event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_OPT_OUT;
+    } else {
+      event = AutofillMetrics::UNMASK_PROMPT_LOCAL_SAVE_DID_OPT_IN;
+    }
+    AutofillMetrics::LogUnmaskPromptEvent(event);
   }
-  AutofillMetrics::LogUnmaskPromptEvent(event);
 }
 
 void CardUnmaskPromptControllerImpl::OnUnmaskResponse(
     const base::string16& cvc,
     const base::string16& exp_month,
     const base::string16& exp_year,
     bool should_store_pan) {
   unmasking_number_of_attempts_++;
   card_unmask_view_->DisableAndWaitForVerification();
 
   DCHECK(!cvc.empty());
   pending_response_.cvc = cvc;
   if (ShouldRequestExpirationDate()) {
     pending_response_.exp_month = exp_month;
     pending_response_.exp_year = exp_year;
   }
-  pending_response_.should_store_pan = should_store_pan;
+  if (CanStoreLocally()) {
+    pending_response_.should_store_pan = should_store_pan;
+  } else {
+    DCHECK(!should_store_pan);
+    pending_response_.should_store_pan = false;
+  }
+
   // Remember the last choice the user made (on this device).
   user_prefs::UserPrefs::Get(web_contents_->GetBrowserContext())->SetBoolean(
       prefs::kAutofillWalletImportStorageCheckboxState, should_store_pan);
 
   if (!pending_response_.risk_data.empty())
     delegate_->OnUnmaskResponse(pending_response_);
 }
 
 content::WebContents* CardUnmaskPromptControllerImpl::GetWebContents() {
   return web_contents_;
@@ skipping 22 matching lines @@
 
 int CardUnmaskPromptControllerImpl::GetCvcImageRid() const {
   return card_.type() == kAmericanExpressCard ? IDR_CREDIT_CARD_CVC_HINT_AMEX
                                               : IDR_CREDIT_CARD_CVC_HINT;
 }
 
 bool CardUnmaskPromptControllerImpl::ShouldRequestExpirationDate() const {
   return card_.GetServerStatus() == CreditCard::EXPIRED;
 }
 
+bool CardUnmaskPromptControllerImpl::CanStoreLocally() const {
+  // TODO(estade): Always return false for Linux. See
+  // https://codereview.chromium.org/1012223002/
+  Profile* profile =
+        Profile::FromBrowserContext(web_contents_->GetBrowserContext());
+  return !profile->IsOffTheRecord();

[please use gerrit instead, 2015/03/23 19:57:58]

nit: Technically, you can save 1 line by inlining "profile."

[Evan Stade, 2015/03/23 21:49:56]

Done.

+}
+
 bool CardUnmaskPromptControllerImpl::GetStoreLocallyStartState() const {
-  // TODO(estade): Don't even offer to save on Linux? Offer to save but
-  // default to false?
   PrefService* prefs =
       user_prefs::UserPrefs::Get(web_contents_->GetBrowserContext());
   return prefs->GetBoolean(prefs::kAutofillWalletImportStorageCheckboxState);
 }
 
 bool CardUnmaskPromptControllerImpl::InputCvcIsValid(
     const base::string16& input_text) const {
   base::string16 trimmed_text;
   base::TrimWhitespace(input_text, base::TRIM_ALL, &trimmed_text);
   size_t input_size = card_.type() == kAmericanExpressCard ? 4 : 3;
@@ skipping 52 matching lines @@
 }
 
 void CardUnmaskPromptControllerImpl::OnDidLoadRiskFingerprint(
     const std::string& risk_data) {
   pending_response_.risk_data = risk_data;
   if (!pending_response_.cvc.empty())
     delegate_->OnUnmaskResponse(pending_response_);
 }
 
 }  // namespace autofill