Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 1011493002: Revert of Improve tracking of bound FBOs in GrGLGpu. (Closed)

Created:
5 years, 9 months ago by bsalomon
Modified:
5 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #12 id:220001 of https://codereview.chromium.org/949263002/) Reason for revert: That one needs to be reverted to fix black boxes with GPU raster, and GPU bot failures. BUG=466690 Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef > > Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1e0bf7e113f994a512a351cc2b25ddb1e742b7d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -383 lines) Patch
M src/gpu/gl/GrGLCaps.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 4 chunks +17 lines, -39 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 33 chunks +184 lines, -201 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 3 chunks +22 lines, -78 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 4 chunks +16 lines, -45 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Improve tracking of bound FBOs in GrGLGpu.
5 years, 9 months ago (2015-03-14 19:08:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011493002/1
5 years, 9 months ago (2015-03-14 19:08:41 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 19:08:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e0bf7e113f994a512a351cc2b25ddb1e742b7d4

Powered by Google App Engine
This is Rietveld 408576698