Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/remoting/host/token_validator_factory_impl.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/remoting/host/pin_hash.cc ('k') | trunk/src/remoting/protocol/auth_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/remoting/host/token_validator_factory_impl.cc
===================================================================
--- trunk/src/remoting/host/token_validator_factory_impl.cc (revision 239920)
+++ trunk/src/remoting/host/token_validator_factory_impl.cc (working copy)
@@ -107,7 +107,8 @@
std::string nonce_bytes;
crypto::RandBytes(WriteInto(&nonce_bytes, kNonceLength + 1), kNonceLength);
std::string nonce;
- base::Base64Encode(nonce_bytes, &nonce);
+ bool success = base::Base64Encode(nonce_bytes, &nonce);
+ DCHECK(success);
return "client:" + remote_jid + " host:" + local_jid + " nonce:" + nonce;
}
« no previous file with comments | « trunk/src/remoting/host/pin_hash.cc ('k') | trunk/src/remoting/protocol/auth_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698