Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/remoting/host/pin_hash.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/remoting/base/rsa_key_pair.cc ('k') | trunk/src/remoting/host/token_validator_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/remoting/host/pin_hash.cc
===================================================================
--- trunk/src/remoting/host/pin_hash.cc (revision 239920)
+++ trunk/src/remoting/host/pin_hash.cc (working copy)
@@ -16,7 +16,9 @@
std::string hash = protocol::AuthenticationMethod::ApplyHashFunction(
protocol::AuthenticationMethod::HMAC_SHA256, host_id, pin);
std::string hash_base64;
- base::Base64Encode(hash, &hash_base64);
+ if (!base::Base64Encode(hash, &hash_base64)) {
+ LOG(FATAL) << "Base64Encode failed";
+ }
return "hmac:" + hash_base64;
}
« no previous file with comments | « trunk/src/remoting/base/rsa_key_pair.cc ('k') | trunk/src/remoting/host/token_validator_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698