Revert 239759 "The comment in base64.h implies that base::Base64..."

trunk/src/remoting/host/token_validator_factory_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/token_validator_factory_impl.h"
 
 #include <set>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 89 matching lines @@
   bool IsValidScope(const std::string& token_scope) {
     // TODO(rmsousa): Deal with reordering/subsets/supersets/aliases/etc.
     return token_scope == token_scope_;
   }
 
   static std::string CreateScope(const std::string& local_jid,
                                  const std::string& remote_jid) {
     std::string nonce_bytes;
     crypto::RandBytes(WriteInto(&nonce_bytes, kNonceLength + 1), kNonceLength);
     std::string nonce;
-    base::Base64Encode(nonce_bytes, &nonce);
+    bool success = base::Base64Encode(nonce_bytes, &nonce);
+    DCHECK(success);
     return "client:" + remote_jid + " host:" + local_jid + " nonce:" + nonce;
   }
 
   std::string ProcessResponse() {
     // Verify that we got a successful response.
     net::URLRequestStatus status = request_->GetStatus();
     if (!status.is_success()) {
       LOG(ERROR) << "Error validating token, status=" << status.status()
                  << " err=" << status.error();
       return std::string();
@@ skipping 60 matching lines @@
 TokenValidatorFactoryImpl::CreateTokenValidator(
     const std::string& local_jid,
     const std::string& remote_jid) {
   return scoped_ptr<protocol::ThirdPartyHostAuthenticator::TokenValidator>(
       new TokenValidatorImpl(token_url_, token_validation_url_, key_pair_,
                              local_jid, remote_jid,
                              request_context_getter_));
 }
 
 }  // namespace remoting