Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1010963002: favor DCHECK_CURRENTLY_ON for better logs in content/{public,shell,test}/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, johnme+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in content/{public,shell,test}/ BUG=466848 Committed: https://crrev.com/4e363898b5d39aebb65fa5eb5f42dc37b9907cc8 Cr-Commit-Position: refs/heads/master@{#321771}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M content/public/browser/push_messaging_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/download_test_observer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/fake_speech_recognition_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_file_error_injector.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_download_manager_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_login_dialog.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/shell/browser/shell_login_dialog_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@nasko: PTAL at content/public/ @pfeldman: PTAL at content/shell/ @Paweł: PTAL at content/test/
5 years, 9 months ago (2015-03-21 23:42:30 UTC) #2
Mike West
content/shell LGTM
5 years, 9 months ago (2015-03-22 05:53:56 UTC) #4
Paweł Hajdan Jr.
content/test LGTM
5 years, 9 months ago (2015-03-23 13:32:05 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-23 13:32:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010963002/20001
5 years, 9 months ago (2015-03-23 13:34:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 14:35:15 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 14:36:14 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4e363898b5d39aebb65fa5eb5f42dc37b9907cc8
Cr-Commit-Position: refs/heads/master@{#321771}

Powered by Google App Engine
This is Rietveld 408576698