Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: content/public/test/download_test_observer.cc

Issue 1010963002: favor DCHECK_CURRENTLY_ON for better logs in content/{public,shell,test}/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/download_test_observer.cc
diff --git a/content/public/test/download_test_observer.cc b/content/public/test/download_test_observer.cc
index 8ce69b8782794ce0e9a3d15eeef1cb1d3a11c2ba..5873df027e24a64a22a2fdaed112b58a55607cdc 100644
--- a/content/public/test/download_test_observer.cc
+++ b/content/public/test/download_test_observer.cc
@@ -314,7 +314,7 @@ DownloadTestFlushObserver::DownloadTestFlushObserver(
waiting_for_zero_inprogress_(true) {}
void DownloadTestFlushObserver::WaitForFlush() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
download_manager_->AddObserver(this);
// The wait condition may have been met before WaitForFlush() was called.
CheckDownloadsInProgress(true);
@@ -422,7 +422,7 @@ DownloadTestItemCreationObserver::~DownloadTestItemCreationObserver() {
}
void DownloadTestItemCreationObserver::WaitForDownloadItemCreation() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (called_back_count_ == 0) {
waiting_ = true;
@@ -434,7 +434,7 @@ void DownloadTestItemCreationObserver::WaitForDownloadItemCreation() {
void DownloadTestItemCreationObserver::DownloadItemCreationCallback(
DownloadItem* item,
DownloadInterruptReason interrupt_reason) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (item)
download_id_ = item->GetId();
« no previous file with comments | « content/public/browser/push_messaging_service.cc ('k') | content/public/test/fake_speech_recognition_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698