Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2008)

Unified Diff: content/shell/browser/shell_login_dialog_mac.mm

Issue 1010963002: favor DCHECK_CURRENTLY_ON for better logs in content/{public,shell,test}/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_login_dialog_mac.mm
diff --git a/content/shell/browser/shell_login_dialog_mac.mm b/content/shell/browser/shell_login_dialog_mac.mm
index 3e014e8791ce42a50ba1bd1ee96ac50bd6182ad0..a7d24566872bafaa165f306ba20571334fc71dde 100644
--- a/content/shell/browser/shell_login_dialog_mac.mm
+++ b/content/shell/browser/shell_login_dialog_mac.mm
@@ -88,7 +88,7 @@ const int kPasswordFieldTag = 2;
namespace content {
void ShellLoginDialog::PlatformCreateDialog(const base::string16& message) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
helper_ = [[ShellLoginDialogHelper alloc] init];
// Show the modal dialog.
@@ -109,13 +109,13 @@ void ShellLoginDialog::PlatformCreateDialog(const base::string16& message) {
}
void ShellLoginDialog::PlatformCleanUp() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
[helper_ release];
helper_ = nil;
}
void ShellLoginDialog::PlatformRequestCancelled() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
[helper_ cancel];
}
« no previous file with comments | « content/shell/browser/shell_login_dialog.cc ('k') | content/shell/browser/shell_url_request_context_getter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698