Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1010363003: Fix the freezing ripple on the cr-settings-menu (Closed)

Created:
5 years, 9 months ago by Jeremy Klein
Modified:
5 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the freezing ripple on the cr-settings-menu by disabling the selectedAttribute as a workaround. See https://github.com/Polymer/polymer/issues/946. R=michaelpg@chromium.org BUG= Committed: https://crrev.com/d67dd33cfa7b9b3a3b716d8bd28735498071621c Cr-Commit-Position: refs/heads/master@{#321498}

Patch Set 1 #

Patch Set 2 : Add a todo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Jeremy Klein
5 years, 9 months ago (2015-03-19 17:08:47 UTC) #1
michaelpg
nice! I'd suggest adding a link to the bug so we know we don't need ...
5 years, 9 months ago (2015-03-19 23:47:49 UTC) #2
Jeremy Klein
On 2015/03/19 23:47:49, michaelpg wrote: > nice! I'd suggest adding a link to the bug ...
5 years, 9 months ago (2015-03-20 00:49:13 UTC) #3
Jeremy Klein
On 2015/03/19 23:47:49, michaelpg wrote: > nice! I'd suggest adding a link to the bug ...
5 years, 9 months ago (2015-03-20 00:49:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010363003/20001
5 years, 9 months ago (2015-03-20 00:50:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 02:24:09 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 02:25:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d67dd33cfa7b9b3a3b716d8bd28735498071621c
Cr-Commit-Position: refs/heads/master@{#321498}

Powered by Google App Engine
This is Rietveld 408576698