chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 1010363003: Fix the freezing ripple on the cr-settings-menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1010363003: Fix the freezing ripple on the cr-settings-menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a todo. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index 5b71c1c91b31399da1661712de394e2196379e5a..22721ba0a3011df8da5d415befd1ac30a6f83f79 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -4,7 +4,11 @@

<polymer-element name="cr-settings-menu">

- <core-menu selected="{{selectedId}}" valueattr="data-id">

+ <!-- TODO(jlklein): selectedAttribute here is a workaround for

+ https://github.com/Polymer/polymer/issues/946. Remove when core-menu

+ is updated. -->

+ <core-menu selected="{{selectedId}}" valueattr="data-id"

+ selectedAttribute="">

<paper-item data-id="{{PAGE_ID}}">

<core-icon icon="{{icon}}"></core-icon>

« no previous file with comments | « no previous file | no next file » | no next file with comments »