Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1010363003: Fix the freezing ripple on the cr-settings-menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a todo. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html"> 1 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">
2 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html"> 2 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">
3 3
4 <polymer-element name="cr-settings-menu"> 4 <polymer-element name="cr-settings-menu">
5 <template> 5 <template>
6 <link rel="stylesheet" href="settings_menu.css"> 6 <link rel="stylesheet" href="settings_menu.css">
7 <core-menu selected="{{selectedId}}" valueattr="data-id"> 7 <!-- TODO(jlklein): selectedAttribute here is a workaround for
8 https://github.com/Polymer/polymer/issues/946. Remove when core-menu
9 is updated. -->
10 <core-menu selected="{{selectedId}}" valueattr="data-id"
11 selectedAttribute="">
8 <template repeat="{{pages}}"> 12 <template repeat="{{pages}}">
9 <paper-item data-id="{{PAGE_ID}}"> 13 <paper-item data-id="{{PAGE_ID}}">
10 <core-icon icon="{{icon}}"></core-icon> 14 <core-icon icon="{{icon}}"></core-icon>
11 {{pageTitle}} 15 {{pageTitle}}
12 </paper-item> 16 </paper-item>
13 </template> 17 </template>
14 </core-menu> 18 </core-menu>
15 </template> 19 </template>
16 <script src="settings_menu.js"></script> 20 <script src="settings_menu.js"></script>
17 </polymer-element> 21 </polymer-element>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698