ui/file_manager/file_manager/foreground/js/naming_controller.js - Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/naming_controller.js

Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Define FakeEntry record type and use it. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/main_window_component.js ('k') | ui/file_manager/file_manager/foreground/js/ui/directory_tree.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/naming_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/naming_controller.js b/ui/file_manager/file_manager/foreground/js/naming_controller.js

index 50a6ff3c70724a431ee78f538ac578d33bbcac35..866cb8eca28d7e9d509e45f38c608fc2cc320794 100644

--- a/ui/file_manager/file_manager/foreground/js/naming_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/naming_controller.js

@@ -94,7 +94,8 @@ NamingController.prototype.validateFileName = function(

* @return {Promise.<string>}

NamingController.prototype.validateFileNameForSaving = function(filename) {

- var directory = this.directoryModel_.getCurrentDirEntry();

+ var directory = /** @type {DirectoryEntry} */ (

+ this.directoryModel_.getCurrentDirEntry());

var currentDirUrl = directory.toURL().replace(/\/?$/, '/');

var fileUrl = currentDirUrl + encodeURIComponent(filename);

@@ -339,7 +340,7 @@ NamingController.prototype.commitRename_ = function() {

// parent if the directory content is a search result. Fix it to do proper

// validation.

this.validateFileName(

- this.directoryModel_.getCurrentDirEntry(),

+ /** @type {DirectoryEntry} */ (this.directoryModel_.getCurrentDirEntry()),

newName,

validationDone.bind(this));

};