Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Define FakeEntry record type and use it. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
index 8e6e1deaab56d61cc641d7b228493db805f795a0..c7483b0a1f59aaf43d8406576ed757dbe13271f4 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
@@ -17,8 +17,8 @@ var DirectoryItemTreeBaseMethods = {};
* Finds a parent directory of the {@code entry} in {@code this}, and
* invokes the DirectoryItem.selectByEntry() of the found directory.
*
- * @param {!DirectoryEntry|!Object} entry The entry to be searched for. Can be
- * a fake.
+ * @param {!DirectoryEntry|!FakeEntry} entry The entry to be searched for. Can
+ * be a fake.
* @return {boolean} True if the parent item is found.
* @this {(DirectoryItem|VolumeItem|DirectoryTree)}
*/
@@ -153,8 +153,8 @@ DirectoryItem.prototype.updateSubElementsFromList = function(recursive) {
/**
* Calls DirectoryItemTreeBaseMethods.updateSubElementsFromList().
*
- * @param {!DirectoryEntry|!Object} entry The entry to be searched for. Can be
- * a fake.
+ * @param {!DirectoryEntry|!FakeEntry} entry The entry to be searched for. Can
+ * be a fake.
* @return {boolean} True if the parent item is found.
*/
DirectoryItem.prototype.searchAndSelectByEntry = function(entry) {
@@ -292,7 +292,7 @@ DirectoryItem.prototype.updateSharedStatusIcon = function() {
/**
* Select the item corresponding to the given {@code entry}.
- * @param {!DirectoryEntry|!Object} entry The entry to be selected. Can be a
+ * @param {!DirectoryEntry|!FakeEntry} entry The entry to be selected. Can be a
* fake.
*/
DirectoryItem.prototype.selectByEntry = function(entry) {
@@ -651,7 +651,7 @@ DriveVolumeItem.prototype.updateItemByEntry = function(changedDirectoryEntry) {
/**
* Select the item corresponding to the given entry.
- * @param {!DirectoryEntry|!Object} entry The directory entry to be selected.
+ * @param {!DirectoryEntry|!FakeEntry} entry The directory entry to be selected.
* Can be a fake.
* @override
*/
@@ -710,8 +710,8 @@ ShortcutItem.prototype = {
* Finds a parent directory of the {@code entry} in {@code this}, and
* invokes the DirectoryItem.selectByEntry() of the found directory.
*
- * @param {!DirectoryEntry|!Object} entry The entry to be searched for. Can be
- * a fake.
+ * @param {!DirectoryEntry|!FakeEntry} entry The entry to be searched for. Can
+ * be a fake.
* @return {boolean} True if the parent item is found.
*/
ShortcutItem.prototype.searchAndSelectByEntry = function(entry) {
@@ -930,8 +930,8 @@ DirectoryTree.prototype.updateSubElementsFromList = function(recursive) {
* Finds a parent directory of the {@code entry} in {@code this}, and
* invokes the DirectoryItem.selectByEntry() of the found directory.
*
- * @param {!DirectoryEntry|!Object} entry The entry to be searched for. Can be
- * a fake.
+ * @param {!DirectoryEntry|!FakeEntry} entry The entry to be searched for. Can
+ * be a fake.
* @return {boolean} True if the parent item is found.
*/
DirectoryTree.prototype.searchAndSelectByEntry = function(entry) {
@@ -996,7 +996,7 @@ DirectoryTree.prototype.decorateDirectoryTree = function(
/**
* Select the item corresponding to the given entry.
- * @param {!DirectoryEntry|!Object} entry The directory entry to be selected.
+ * @param {!DirectoryEntry|!FakeEntry} entry The directory entry to be selected.
* Can be a fake.
*/
DirectoryTree.prototype.selectByEntry = function(entry) {

Powered by Google App Engine
This is Rietveld 408576698