ui/file_manager/file_manager/foreground/js/main_window_component.js - Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/main_window_component.js

Issue 1010163002: Files.app: Fix closure error which will raised by the updated compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Define FakeEntry record type and use it. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/import_controller.js ('k') | ui/file_manager/file_manager/foreground/js/naming_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/main_window_component.js

diff --git a/ui/file_manager/file_manager/foreground/js/main_window_component.js b/ui/file_manager/file_manager/foreground/js/main_window_component.js

index 007d3a6fe6c38dfc50ede8464a192f6423b83b5d..aa88065ac1920190868aa5f523c8794d7945a9c5 100644

--- a/ui/file_manager/file_manager/foreground/js/main_window_component.js

+++ b/ui/file_manager/file_manager/foreground/js/main_window_component.js

@@ -185,7 +185,8 @@ MainWindowComponent.prototype.onDetailClick_ = function(event) {

var entry = selection.entries[0];

if (entry.isDirectory) {

- this.directoryModel_.changeDirectoryEntry(entry);

+ this.directoryModel_.changeDirectoryEntry(

+ /** @type {!DirectoryEntry} */ (entry));

} else {

this.taskController_.dispatchSelectionAction();

}

@@ -278,7 +279,8 @@ MainWindowComponent.prototype.onListKeyDown_ = function(event) {

// directory.

if (item && !item.hasAttribute('renaming')) {

event.preventDefault();

- this.directoryModel_.changeDirectoryEntry(selection.entries[0]);

+ this.directoryModel_.changeDirectoryEntry(

+ /** @type {!DirectoryEntry} */ (selection.entries[0]));

}

} else if (this.taskController_.dispatchSelectionAction()) {

event.preventDefault();