Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1009603006: Add a note that landmines should not be used in general. (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a note that landmines should not be used in general. BUG=none Committed: https://crrev.com/37066a5a215e8c8e85958e7b1c7756b201b17c5c Cr-Commit-Position: refs/heads/master@{#321824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/get_landmines.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Nico
5 years, 9 months ago (2015-03-23 16:41:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-23 16:43:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009603006/1
5 years, 9 months ago (2015-03-23 18:01:54 UTC) #5
iannucci
On 2015/03/23 18:01:54, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-23 18:09:06 UTC) #6
jochen (gone - plz use gerrit)
I guess this was triggered by https://codereview.chromium.org/1007423004 Comments on that issue welcome
5 years, 9 months ago (2015-03-23 18:12:15 UTC) #7
iannucci
On 2015/03/23 18:12:15, jochen (slow) wrote: > I guess this was triggered by https://codereview.chromium.org/1007423004 > ...
5 years, 9 months ago (2015-03-23 18:14:37 UTC) #8
Nico
On 2015/03/23 18:12:15, jochen (slow) wrote: > I guess this was triggered by https://codereview.chromium.org/1007423004 This ...
5 years, 9 months ago (2015-03-23 18:15:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 18:58:01 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:58:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37066a5a215e8c8e85958e7b1c7756b201b17c5c
Cr-Commit-Position: refs/heads/master@{#321824}

Powered by Google App Engine
This is Rietveld 408576698