Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: build/get_landmines.py

Issue 1009603006: Add a note that landmines should not be used in general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
11 import sys 11 import sys
12 12
13 import landmine_utils 13 import landmine_utils
14 14
15 15
16 builder = landmine_utils.builder 16 builder = landmine_utils.builder
17 distributor = landmine_utils.distributor 17 distributor = landmine_utils.distributor
18 gyp_defines = landmine_utils.gyp_defines 18 gyp_defines = landmine_utils.gyp_defines
19 gyp_msvs_version = landmine_utils.gyp_msvs_version 19 gyp_msvs_version = landmine_utils.gyp_msvs_version
20 platform = landmine_utils.platform 20 platform = landmine_utils.platform
21 21
22 22
23 def print_landmines(): 23 def print_landmines():
24 """ 24 """
25 ALL LANDMINES ARE EMITTED FROM HERE. 25 ALL LANDMINES ARE EMITTED FROM HERE.
26 """ 26 """
27 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort
28 # bandaid fix if a CL that got landed has a build dependency bug and all bots
29 # need to be cleaned up. If you're writing a new CL that causes build
30 # dependency problems, fix the dependency problems instead of adding a
31 # landmine.
32
27 if (distributor() == 'goma' and platform() == 'win32' and 33 if (distributor() == 'goma' and platform() == 'win32' and
28 builder() == 'ninja'): 34 builder() == 'ninja'):
29 print 'Need to clobber winja goma due to backend cwd cache fix.' 35 print 'Need to clobber winja goma due to backend cwd cache fix.'
30 if platform() == 'android': 36 if platform() == 'android':
31 print 'Clobber: to handle new way of suppressing findbugs failures.' 37 print 'Clobber: to handle new way of suppressing findbugs failures.'
32 print 'Clobber to fix gyp not rename package name (crbug.com/457038)' 38 print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
33 if platform() == 'win' and builder() == 'ninja': 39 if platform() == 'win' and builder() == 'ninja':
34 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 40 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
35 if platform() == 'linux' and builder() == 'ninja': 41 if platform() == 'linux' and builder() == 'ninja':
36 print 'Builders switching from make to ninja will clobber on this.' 42 print 'Builders switching from make to ninja will clobber on this.'
(...skipping 28 matching lines...) Expand all
65 print 'Remove NaCl toolchains from the output dir (crbug.com/456902)' 71 print 'Remove NaCl toolchains from the output dir (crbug.com/456902)'
66 72
67 73
68 def main(): 74 def main():
69 print_landmines() 75 print_landmines()
70 return 0 76 return 0
71 77
72 78
73 if __name__ == '__main__': 79 if __name__ == '__main__':
74 sys.exit(main()) 80 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698