Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1007423004: Switch STL implementation for iOS from libc++ to libstdc++ (Closed)

Created:
5 years, 9 months ago by pkl (ping after 24h if needed)
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch STL implementation for iOS from libc++ to libstdc++ This change applies to iOS builds only. The use_system_libcxx flag is set to use libstdc++. BUG=459012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/get_landmines.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (3 generated)
pkl (ping after 24h if needed)
5 years, 9 months ago (2015-03-18 18:13:16 UTC) #2
sdefresne
lgtm
5 years, 9 months ago (2015-03-19 08:10:34 UTC) #3
sdefresne
Can you edit the description and make it clear that this only affect iOS builds ...
5 years, 9 months ago (2015-03-19 08:11:05 UTC) #4
pkl (ping after 24h if needed)
On 2015/03/19 08:11:05, sdefresne wrote: > Can you edit the description and make it clear ...
5 years, 9 months ago (2015-03-19 09:04:03 UTC) #5
sdefresne
Still lgtm.
5 years, 9 months ago (2015-03-19 09:06:41 UTC) #6
pkl (ping after 24h if needed)
+jochen for OWNERS approval. Thanks!
5 years, 9 months ago (2015-03-19 09:11:28 UTC) #8
jochen (gone - plz use gerrit)
why does it need a landmine?
5 years, 9 months ago (2015-03-19 10:25:27 UTC) #9
pkl (ping after 24h if needed)
On 2015/03/19 10:25:27, jochen (slow) wrote: > why does it need a landmine? Without the ...
5 years, 9 months ago (2015-03-19 10:33:54 UTC) #10
pkl (ping after 24h if needed)
jochen: friendly ping.
5 years, 9 months ago (2015-03-20 10:31:57 UTC) #11
jochen (gone - plz use gerrit)
+thakis usually, we try to avoid landmines. How difficult will it be to fix the ...
5 years, 9 months ago (2015-03-20 14:47:18 UTC) #13
pkl (ping after 24h if needed)
On 2015/03/20 14:47:18, jochen (slow) wrote: > +thakis > > usually, we try to avoid ...
5 years, 9 months ago (2015-03-23 10:18:26 UTC) #14
jochen (gone - plz use gerrit)
the thing is that this will likely tank the cycle time of ios builders for ...
5 years, 9 months ago (2015-03-23 10:23:08 UTC) #15
Nico
On 2015/03/23 10:18:26, pklpkl wrote: > On 2015/03/20 14:47:18, jochen (slow) wrote: > > +thakis ...
5 years, 9 months ago (2015-03-23 18:20:08 UTC) #16
sdefresne
5 years, 6 months ago (2015-06-08 16:25:01 UTC) #17
On 2015/03/23 18:20:08, Nico wrote:
> On 2015/03/23 10:18:26, pklpkl wrote:
> > On 2015/03/20 14:47:18, jochen (slow) wrote:
> > > +thakis
> > > 
> > > usually, we try to avoid landmines. How difficult will it be to fix the
> > > dependency checker instead?
> > 
> > The landmine added by this CL affects iOS builds only. Due to crbug/469223,
I
> > would like to switch iOS builds back to libstdc++ asap and would rather not
> wait
> > for crbug/459197 to be fixed.
> 
> You could fix it yourself :-)

Can this CL be closed?

Powered by Google App Engine
This is Rietveld 408576698