Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1009543009: Re-land: Return the accessible selection bounds in password fields. (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 9 months ago
Reviewers:
aboxhall
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-land: Return the accessible selection bounds in password fields. There's no reason not to return it. This code was originally added to WebKit to mimic the behavior of other Mac fields, but it seems to work fine without it. While we're at it, make sure that role=textbox is exposed as a password field, too. BUG=84250 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192230

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
A LayoutTests/accessibility/input-type-password-selection.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/input-type-password-selection-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
dmazzoni
5 years, 9 months ago (2015-03-18 21:29:09 UTC) #2
aboxhall
lgtm
5 years, 9 months ago (2015-03-18 21:31:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009543009/20001
5 years, 9 months ago (2015-03-18 21:36:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192125
5 years, 9 months ago (2015-03-18 23:23:50 UTC) #6
pfeldman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1016293002/ by pfeldman@chromium.org. ...
5 years, 9 months ago (2015-03-19 09:18:46 UTC) #7
dmazzoni
Test disabled so it can be rebaselined. Landing again.
5 years, 9 months ago (2015-03-20 05:01:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009543009/20001
5 years, 9 months ago (2015-03-20 05:01:31 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 07:14:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192230

Powered by Google App Engine
This is Rietveld 408576698