Source/modules/accessibility/AXLayoutObject.cpp - Issue 1009543009: Re-land: Return the accessible selection bounds in password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1009543009: Re-land: Return the accessible selection bounds in password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/input-type-password-selection-expected.txt ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp

index 4fe12bb83466203ac5c744888b02b22dcd6db3f6..c956bc499306fd2c24e6e0e32ab4fa7fd5be3d81 100644

--- a/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1660,9 +1660,6 @@ AXObject::PlainTextRange AXLayoutObject::selectedTextRange() const

if (!isTextControl())

return PlainTextRange();

- if (isPasswordFieldAndShouldHideValue())

- return PlainTextRange();

AccessibilityRole ariaRole = ariaRoleAttribute();

if (isNativeTextControl() && ariaRole == UnknownRole && m_layoutObject->isTextControl()) {

HTMLTextFormControlElement* textControl = toLayoutTextControl(m_layoutObject)->textFormControlElement();