Source/modules/accessibility/AXNodeObject.cpp - Issue 1009543009: Re-land: Return the accessible selection bounds in password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1009543009: Re-land: Return the accessible selection bounds in password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index 75cd4a77849ba1a7e80ddbcd4286a37584464f44..fa81ede595dade2494b08e6a0fdb51b680db5a3a 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -671,7 +671,8 @@ bool AXNodeObject::isPasswordField() const

if (!isHTMLInputElement(node))

return false;

- if (ariaRoleAttribute() != UnknownRole)

+ AccessibilityRole ariaRole = ariaRoleAttribute();

+ if (ariaRole != TextFieldRole && ariaRole != TextAreaRole)

return false;

return toHTMLInputElement(node)->type() == InputTypeNames::password;

« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »