chrome/browser/background/background_contents.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/background/background_contents.h

diff --git a/chrome/browser/background/background_contents.h b/chrome/browser/background/background_contents.h

index e3a07753b7e590904d425eb092ee439db39766c3..9d8dbbcad1a8f22dda8a1f646bf4508395769480 100644

--- a/chrome/browser/background/background_contents.h

+++ b/chrome/browser/background/background_contents.h

@@ -81,8 +81,8 @@ class BackgroundContents : public extensions::DeferredStartRenderHost,

// content::WebContentsObserver implementation:

void RenderProcessGone(base::TerminationStatus status) override;

- void DidStartLoading(content::RenderViewHost* render_view_host) override;

- void DidStopLoading(content::RenderViewHost* render_view_host) override;

+ void DidStartLoading() override;

+ void DidStopLoading() override;

// content::NotificationObserver

void Observe(int type,

« no previous file with comments | « no previous file | chrome/browser/background/background_contents.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')