chrome/browser/background/background_contents.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents.h ('k') | chrome/browser/captive_portal/captive_portal_tab_helper.h » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents.cc

diff --git a/chrome/browser/background/background_contents.cc b/chrome/browser/background/background_contents.cc

index f0356599d2e4e9d952d9a622b6e3853917f6021d..2f20e23793f47719a661535b624b3b364f22f53b 100644

--- a/chrome/browser/background/background_contents.cc

+++ b/chrome/browser/background/background_contents.cc

@@ -162,15 +162,13 @@ void BackgroundContents::RenderProcessGone(base::TerminationStatus status) {

delete this;

}

-void BackgroundContents::DidStartLoading(

- content::RenderViewHost* render_view_host) {

+void BackgroundContents::DidStartLoading() {

FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,

deferred_start_render_host_observer_list_,

OnDeferredStartRenderHostDidStartLoading(this));

}

-void BackgroundContents::DidStopLoading(

- content::RenderViewHost* render_view_host) {

+void BackgroundContents::DidStopLoading() {

FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,

deferred_start_render_host_observer_list_,

OnDeferredStartRenderHostDidStopLoading(this));