Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android + Review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index 3a3c7ffe8ac87f431107bc96ad8dc1c06b4b2652..7edb750265fd0975b32ba8ac2e9ad2e287993035 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -518,18 +518,20 @@ double GuestViewBase::PhysicalPixelsToLogicalPixels(int physical_pixels) {
return physical_pixels / zoom_factor;
}
-void GuestViewBase::DidStopLoading(content::RenderViewHost* render_view_host) {
+void GuestViewBase::DidStopLoading() {
+ content::RenderViewHost* rvh = web_contents()->GetRenderViewHost();
+
if (IsPreferredSizeModeEnabled()) {
Fady Samuel 2015/03/14 04:25:02 nit: Could you please get rid of these unnecessary
Fabrice (no longer in Chrome) 2015/03/16 11:56:13 Done.
- render_view_host->EnablePreferredSizeMode();
+ rvh->EnablePreferredSizeMode();
}
if (!IsDragAndDropEnabled()) {
- const char script[] = "window.addEventListener('dragstart', function() { "
- " window.event.preventDefault(); "
- "});";
- render_view_host->GetMainFrame()->ExecuteJavaScript(
- base::ASCIIToUTF16(script));
+ const char script[] =
+ "window.addEventListener('dragstart', function() { "
+ " window.event.preventDefault(); "
+ "});";
+ rvh->GetMainFrame()->ExecuteJavaScript(base::ASCIIToUTF16(script));
}
- DidStopLoading();
+ GuestViewDidStopLoading();
}
void GuestViewBase::RenderViewReady() {
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698