Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1008723004: Add support for reporting history load with counts + timing + a 'multi-machine' dimension. (Closed)

Created:
5 years, 9 months ago by Steve McKay
Modified:
5 years, 9 months ago
Reviewers:
Ben Kwa
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for reporting history load with counts + timing + a 'multi-machine' dimension. TEST=*ImportHistory* TBR=hirono // for background.js Committed: https://crrev.com/875b896a3256c5b86c8725e81489e99ea6c2b4c9 Cr-Commit-Position: refs/heads/master@{#321232}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -22 lines) Patch
M ui/file_manager/file_manager/background/js/background.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/file_operation_util.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/import_history.js View 9 chunks +44 lines, -9 lines 4 comments Download
M ui/file_manager/file_manager/background/js/import_history_unittest.html View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/import_history_unittest.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/metrics_events.js View 5 chunks +22 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/common/js/test_tracker.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Steve McKay
5 years, 9 months ago (2015-03-18 18:19:52 UTC) #2
Steve McKay
+hirono for background.js
5 years, 9 months ago (2015-03-18 18:23:59 UTC) #4
Ben Kwa
lgtm with a couple of questions. https://codereview.chromium.org/1008723004/diff/1/ui/file_manager/file_manager/background/js/import_history.js File ui/file_manager/file_manager/background/js/import_history.js (right): https://codereview.chromium.org/1008723004/diff/1/ui/file_manager/file_manager/background/js/import_history.js#newcode783 ui/file_manager/file_manager/background/js/import_history.js:783: * @param {?} ...
5 years, 9 months ago (2015-03-18 21:37:15 UTC) #5
Steve McKay
Thanks! https://codereview.chromium.org/1008723004/diff/1/ui/file_manager/file_manager/background/js/import_history.js File ui/file_manager/file_manager/background/js/import_history.js (right): https://codereview.chromium.org/1008723004/diff/1/ui/file_manager/file_manager/background/js/import_history.js#newcode783 ui/file_manager/file_manager/background/js/import_history.js:783: * @param {?} ignored On 2015/03/18 21:37:15, Ben ...
5 years, 9 months ago (2015-03-18 22:47:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008723004/1
5 years, 9 months ago (2015-03-18 22:48:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 23:28:25 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 23:31:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/875b896a3256c5b86c8725e81489e99ea6c2b4c9
Cr-Commit-Position: refs/heads/master@{#321232}

Powered by Google App Engine
This is Rietveld 408576698