Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: ui/file_manager/file_manager/common/js/metrics_events.js

Issue 1008723004: Add support for reporting history load with counts + timing + a 'multi-machine' dimension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/common/js/metrics_events.js
diff --git a/ui/file_manager/file_manager/common/js/metrics_events.js b/ui/file_manager/file_manager/common/js/metrics_events.js
index c3b28c3e9556d4ef61ebc66b7d6eb8b56d42d8ef..8fa8549b5c06cc1b3f11c0591c85bd7a137c33af 100644
--- a/ui/file_manager/file_manager/common/js/metrics_events.js
+++ b/ui/file_manager/file_manager/common/js/metrics_events.js
@@ -15,20 +15,21 @@ metrics.Categories = {
* @private @enum {number}
*/
metrics.Dimension_ = {
- USER_TYPE: 1,
- SESSION_TYPE: 2
+ CONSUMER_TYPE: 1,
+ SESSION_TYPE: 2,
+ MACHINE_USE: 3
};
/**
* @enum {!analytics.EventBuilder.Dimension}
*/
metrics.Dimensions = {
- USER_TYPE_NON_IMPORT: {
- index: metrics.Dimension_.USER_TYPE,
+ CONSUMER_TYPE_READER: {
+ index: metrics.Dimension_.CONSUMER_TYPE,
value: 'Non-import'
},
- USER_TYPE_IMPORT: {
- index: metrics.Dimension_.USER_TYPE,
+ CONSUMER_TYPE_IMPORTER: {
+ index: metrics.Dimension_.CONSUMER_TYPE,
value: 'Import'
},
SESSION_TYPE_NON_IMPORT: {
@@ -38,6 +39,14 @@ metrics.Dimensions = {
SESSION_TYPE_IMPORT: {
index: metrics.Dimension_.SESSION_TYPE,
value: 'Import'
+ },
+ MACHINE_USE_SINGLE: {
+ index: metrics.Dimension_.MACHINE_USE,
+ value: 'Single'
+ },
+ MACHINE_USE_MULTIPLE: {
+ index: metrics.Dimension_.MACHINE_USE,
+ value: 'Multiple'
}
};
@@ -60,7 +69,7 @@ metrics.ImportEvents = {
STARTED: metrics.event.Builders_.IMPORT
.action('Import Started')
.dimension(metrics.Dimensions.SESSION_TYPE_IMPORT)
- .dimension(metrics.Dimensions.USER_TYPE_IMPORT),
+ .dimension(metrics.Dimensions.CONSUMER_TYPE_IMPORTER),
CANCELLED: metrics.event.Builders_.IMPORT
.action('Import Cancelled'),
@@ -78,7 +87,10 @@ metrics.ImportEvents = {
.action('Device Yanked'),
FILES_DEDUPLICATED: metrics.event.Builders_.IMPORT
- .action('Files Deduplicated')
+ .action('Files Deduplicated'),
+
+ HISTORY_LOADED: metrics.event.Builders_.IMPORT
+ .action('History Loaded')
};
// namespace
@@ -87,5 +99,6 @@ metrics.timing = metrics.timing || {};
/** @enum {string} */
metrics.timing.Variables = {
COMPUTE_HASH: 'Compute Content Hash',
- SEARCH_BY_HASH: 'Search By Hash'
+ SEARCH_BY_HASH: 'Search By Hash',
+ HISTORY_LOAD: 'History Load'
};

Powered by Google App Engine
This is Rietveld 408576698