ui/file_manager/file_manager/background/js/import_history_unittest.js - Issue 1008723004: Add support for reporting history load with counts + timing + a 'multi-machine' dimension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/background/js/import_history_unittest.js

Issue 1008723004: Add support for reporting history load with counts + timing + a 'multi-machine' dimension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/file_manager/background/js/import_history.js ('K') | « ui/file_manager/file_manager/background/js/import_history_unittest.html ('k') | ui/file_manager/file_manager/common/js/metrics_events.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/background/js/import_history_unittest.js

diff --git a/ui/file_manager/file_manager/background/js/import_history_unittest.js b/ui/file_manager/file_manager/background/js/import_history_unittest.js

index a97a37c9d8df4dba4b370049c627a6583a26caf3..8af22cf9ea0e439cb30a1a6d04766fad2dea81c5 100644

--- a/ui/file_manager/file_manager/background/js/import_history_unittest.js

+++ b/ui/file_manager/file_manager/background/js/import_history_unittest.js

@@ -350,10 +350,11 @@ function installTestLogger() {

function createRealStorage(fileNames) {

var filePromises = fileNames.map(createFileEntry);

+ var tracker = new TestTracker();

return Promise.all(filePromises)

.then(

function(fileEntries) {

- return new importer.FileBasedRecordStorage(fileEntries);

+ return new importer.FileBasedRecordStorage(fileEntries, tracker);

});

}