chrome/test/chromedriver/chrome/adb_impl.cc - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/adb_impl.cc

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/adb_impl.cc

diff --git a/chrome/test/chromedriver/chrome/adb_impl.cc b/chrome/test/chromedriver/chrome/adb_impl.cc

index b2373e58a9780c78da901f9de2cfc5817145c696..0fa1478ab860bcfa853a9705f50e9efa3d35a174 100644

--- a/chrome/test/chromedriver/chrome/adb_impl.cc

+++ b/chrome/test/chromedriver/chrome/adb_impl.cc

@@ -119,7 +119,7 @@ Status AdbImpl::SetCommandLineFile(const std::string& device_serial,

const std::string& args) {

std::string response;

std::string quoted_command =

- base::GetDoubleQuotedJson(exec_name + " " + args);

+ base::GetQuotedJSONString(exec_name + " " + args);

Status status = ExecuteHostShellCommand(

device_serial,

base::StringPrintf("echo %s > %s; echo $?",

Mark Mentovai 2013/12/06 15:35:12 Oh my.

Robert Sesek 2013/12/09 19:52:09 Yes, I didn't even want to go there.