chrome/test/chromedriver/capabilities.cc - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/capabilities.cc

diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc

index 6e884c907d31bef0c4d9f7d36f67083df97822c8..092855ced8ef5107fb9f2bd41abe3aa0e5ebc894 100644

--- a/chrome/test/chromedriver/capabilities.cc

+++ b/chrome/test/chromedriver/capabilities.cc

@@ -393,7 +393,7 @@ std::string Switches::ToString() const {

std::string value = GetSwitchValue(iter->first);

if (value.length()) {

if (value.find(' ') != std::string::npos)

- value = base::GetDoubleQuotedJson(value);

+ value = base::GetQuotedJSONString(value);

str += "=" + value;

}

++iter;