components/plugins/renderer/plugin_placeholder.cc - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/plugin_placeholder.cc

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/plugin_placeholder.cc

diff --git a/components/plugins/renderer/plugin_placeholder.cc b/components/plugins/renderer/plugin_placeholder.cc

index b4b725b28a044ca40ad9ff3d0a4638f120b26993..a1639640a30b1f4b504d610c273b0955faebcfda 100644

--- a/components/plugins/renderer/plugin_placeholder.cc

+++ b/components/plugins/renderer/plugin_placeholder.cc

@@ -165,7 +165,7 @@ void PluginPlaceholder::SetMessage(const string16& message) {

void PluginPlaceholder::UpdateMessage() {

std::string script =

- "window.setMessage(" + base::GetDoubleQuotedJson(message_) + ")";

+ "window.setMessage(" + base::GetQuotedJSONString(message_) + ")";

plugin_->web_view()->mainFrame()->executeScript(

WebScriptSource(ASCIIToUTF16(script)));

}