Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 10082019: Have LazyBackgroundTaskQueue notify consumers when the transient page fails to (Closed)

Created:
7 years, 3 months ago by Matt Perry
Modified:
7 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Have LazyBackgroundTaskQueue notify consumers when the transient page fails to load, so they can do whatever cleanup is necessary. BUG=119620 TEST=no TBR=arv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132441

Patch Set 1 #

Total comments: 4

Patch Set 2 : yoyo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -35 lines) Patch
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.h View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 5 chunks +36 lines, -25 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Perry
7 years, 3 months ago (2012-04-13 20:28:12 UTC) #1
Yoyo Zhou
http://codereview.chromium.org/10082019/diff/1/chrome/browser/extensions/api/runtime/runtime_api.cc File chrome/browser/extensions/api/runtime/runtime_api.cc (right): http://codereview.chromium.org/10082019/diff/1/chrome/browser/extensions/api/runtime/runtime_api.cc#newcode60 chrome/browser/extensions/api/runtime/runtime_api.cc:60: if (host) If not, it looks like the async ...
7 years, 3 months ago (2012-04-13 20:43:52 UTC) #2
Matt Perry
arv: OWNERS rubberstamp for webui? http://codereview.chromium.org/10082019/diff/1/chrome/browser/extensions/api/runtime/runtime_api.cc File chrome/browser/extensions/api/runtime/runtime_api.cc (right): http://codereview.chromium.org/10082019/diff/1/chrome/browser/extensions/api/runtime/runtime_api.cc#newcode60 chrome/browser/extensions/api/runtime/runtime_api.cc:60: if (host) On 2012/04/13 ...
7 years, 3 months ago (2012-04-13 21:19:09 UTC) #3
Yoyo Zhou
LGTM
7 years, 3 months ago (2012-04-13 21:26:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10082019/9
7 years, 3 months ago (2012-04-13 21:26:56 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2012-04-13 22:00:19 UTC) #6
Try job failure for 10082019-9 (retry) on linux_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698