chrome/browser/extensions/api/runtime/runtime_api.cc - Issue 10082019: Have LazyBackgroundTaskQueue notify consumers when the transient page fails to

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/runtime/runtime_api.cc

Issue 10082019: Have LazyBackgroundTaskQueue notify consumers when the transient page fails to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/runtime/runtime_api.h"	5 #include "chrome/browser/extensions/api/runtime/runtime_api.h"

6	6

7 #include "chrome/common/extensions/extension.h"	7 #include "chrome/common/extensions/extension.h"

8 #include "chrome/browser/extensions/extension_event_router.h"	8 #include "chrome/browser/extensions/extension_event_router.h"

9 #include "chrome/browser/extensions/extension_host.h"	9 #include "chrome/browser/extensions/extension_host.h"

10 #include "chrome/browser/extensions/extension_process_manager.h"	10 #include "chrome/browser/extensions/extension_process_manager.h"

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 base::Bind(&RuntimeGetBackgroundPageFunction::OnPageLoaded,	49 base::Bind(&RuntimeGetBackgroundPageFunction::OnPageLoaded,

50 this));	50 this));

51 } else {	51 } else {

52 error_ = kNoBackgroundPageError;	52 error_ = kNoBackgroundPageError;

53 return false;	53 return false;

54 }	54 }

55	55

56 return true;	56 return true;

57 }	57 }

58	58

59 void RuntimeGetBackgroundPageFunction::OnPageLoaded(ExtensionHost*) {	59 void RuntimeGetBackgroundPageFunction::OnPageLoaded(ExtensionHost* host) {

60 SendResponse(true);	60 if (host)
	Yoyo Zhou 2012/04/13 20:43:52 If not, it looks like the async function will neve If not, it looks like the async function will never return one way or another. Matt Perry 2012/04/13 21:19:09 Good catch, fixed! Show quoted text On 2012/04/13 20:43:52, Yoyo Zhou wrote: > If not, it looks like the async function will never return one way or another. Good catch, fixed!
	61 SendResponse(true);

61 }	62 }

62	63

63 } // namespace extensions	64 } // namespace extensions

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_event_router.cc » ('j') | chrome/browser/extensions/lazy_background_task_queue.cc » ('J')