Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1007903004: Telemetry: Finish documenting exceptions thrown by tab.py. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Finish documenting exceptions thrown by tab.py. All the major work has already been done. This CL just finishes flushing out the documentation on tab.py and web_contents.py so that consumers know exactly which exceptions can be thrown. This CL contains one small behavioral change: InspectorBackend.IsInspectable() catches DevToolsClientConnectionError and returns False. This is useful since IsInspectable() gets called in the exception handling code, and no other consumers of IsInspectable expect the method to throw an exception. BUG=460625 Committed: https://crrev.com/4596fc4c841d807fe165fc8fcd5cb0f1fdb89b98 Cr-Commit-Position: refs/heads/master@{#321393}

Patch Set 1 #

Patch Set 2 : Rebase against top of tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -18 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 3 chunks +13 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py View 2 chunks +9 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/tab.py View 8 chunks +56 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/web_contents.py View 1 8 chunks +47 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
erikchen
dtu: Please review.
5 years, 9 months ago (2015-03-18 23:00:12 UTC) #2
dtu
lgtm
5 years, 9 months ago (2015-03-18 23:01:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007903004/1
5 years, 9 months ago (2015-03-18 23:02:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/44932)
5 years, 9 months ago (2015-03-19 00:14:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007903004/20001
5 years, 9 months ago (2015-03-19 00:21:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/47123)
5 years, 9 months ago (2015-03-19 02:06:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007903004/20001
5 years, 9 months ago (2015-03-19 17:44:01 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 18:22:48 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 18:23:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4596fc4c841d807fe165fc8fcd5cb0f1fdb89b98
Cr-Commit-Position: refs/heads/master@{#321393}

Powered by Google App Engine
This is Rietveld 408576698