Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 1007903004: Telemetry: Finish documenting exceptions thrown by tab.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase against top of tree. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
index 63382b2255cc433e999b66aff834c35e231b4cee..d9e8c97210b37f639bec09dc1eba2ab744b4e368 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
@@ -11,6 +11,7 @@ import sys
from telemetry import decorators
from telemetry.core import exceptions
from telemetry.core import util
+from telemetry.core.backends.chrome_inspector import devtools_http
from telemetry.core.backends.chrome_inspector import inspector_console
from telemetry.core.backends.chrome_inspector import inspector_memory
from telemetry.core.backends.chrome_inspector import inspector_network
@@ -108,12 +109,11 @@ class InspectorBackend(object):
return self._context['webSocketDebuggerUrl']
def IsInspectable(self):
- """Whether the tab is inspectable, as reported by devtools.
-
- Raises:
- devtools_http.DevToolsClientConnectionError
- """
- return self._devtools_client.IsInspectable(self.id)
+ """Whether the tab is inspectable, as reported by devtools."""
+ try:
+ return self._devtools_client.IsInspectable(self.id)
+ except devtools_http.DevToolsClientConnectionError:
+ return False
# Public methods implemented in JavaScript.
@@ -146,6 +146,13 @@ class InspectorBackend(object):
@_HandleInspectorWebSocketExceptions
def GetDOMStats(self, timeout):
+ """Gets memory stats from the DOM.
+
+ Raises:
+ inspector_memory.InspectorMemoryException
+ exceptions.TimeoutException
+ exceptions.DevtoolsTargetCrashException
+ """
dom_counters = self._memory.GetDOMCounters(timeout)
return {
'document_count': dom_counters['documents'],
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698