tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py - Issue 1007903004: Telemetry: Finish documenting exceptions thrown by tab.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py

Issue 1007903004: Telemetry: Finish documenting exceptions thrown by tab.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against top of tree. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py ('k') | tools/telemetry/telemetry/core/tab.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py

index b831f71eb90af6bff248ec1ad40fe16412743bea..cd4ddf01a7faa13d8f50f751dbd53a07db206894 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory.py

@@ -3,10 +3,13 @@

# found in the LICENSE file.

import json

+from telemetry.core import exceptions

-class InspectorMemoryException(Exception):

+class InspectorMemoryException(exceptions.Error):

pass

class InspectorMemory(object):

"""Communicates with the remote inspector's Memory domain."""

@@ -27,6 +30,11 @@ class InspectorMemory(object):

Returns:

A dictionary containing the counts associated with "nodes", "documents",

and "jsEventListeners".

+ Raises:

+ InspectorMemoryException

+ websocket.WebSocketException

+ socket.error

+ exceptions.WebSocketDisconnected

"""

res = self._inspector_websocket.SyncRequest({

'method': 'Memory.getDOMCounters'