Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1007443004: Plugin Power Saver: Replace all "plug-in" with "plugin" for consistency. (Closed)

Created:
5 years, 9 months ago by tommycli
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asanka, je_julie(Not used), oshima+watch_chromium.org, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, teravest+watch_chromium.org, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, Sam Clegg, nkostylev+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, jam, raymes+watch_chromium.org, binji+watch_chromium.org, stuartmorgan, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, ihf+watch_chromium.org, dbeam+watch-options_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-options_chromium.org, plundblad+watch_chromium.org, nektar+watch_chromium.org, mcasas+watch_chromium.org, benjhayden+dwatch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Replace all "plug-in" with "plugin" for consistency. Passed chrome-ui-review: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/FwuQ2TWc5n8/H3PSuV4L_cAJ BUG=467165 TBR=tsepez (comment changes only in render_messages) NOPRESUBMIT=true (legacy LOG messages) Committed: https://crrev.com/e86b2982a90cc87afbeb8599cc54c274c482b0ec Cr-Commit-Position: refs/heads/master@{#320782}

Patch Set 1 #

Patch Set 2 : Undo some string literal and URL changes. #

Patch Set 3 : remove terms and native_client_sdk changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -428 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromium_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 18 chunks +103 lines, -103 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_finder.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_metadata_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/plugins/plugin_status_pref_setter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugins_resource_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory_mac.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/about_os_credits.html View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugin_metadata/plugins_mac.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugin_metadata/plugins_win.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/content_settings.json View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contentSettings/popup.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/_locales/en/messages.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/chrome_stubs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/main.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/plugin_list.js View 8 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/plugin_settings.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/contentSettings.html View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/mac/cfbundle_blocker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/mac/cfbundle_blocker.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/pref_names.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/render_messages.h View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/permissions/nacl_enabled/background.html View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M components/plugins/renderer/webview_plugin.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/app/strings/content_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_data_remover_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_service_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/npapi/plugin_host.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/npapi/webplugin_ime_win.h View 7 chunks +18 lines, -18 lines 0 comments Download
M content/child/npapi/webplugin_ime_win.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/child/plugin_messages.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/plugin_list.h View 5 chunks +7 lines, -7 lines 0 comments Download
M content/common/plugin_list.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/process_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_init_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/plugin_data_remover.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/plugin_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/plugin_service_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/sandbox_init.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/webplugininfo.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_process_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_broker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/tools/plugin/PluginObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/PluginObjectMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/PluginTest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/PluginTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/PluginScriptableNPObjectInvokeDefault.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/npapi_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/test/plugin/plugin_setup_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_thread_async_call_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/utility/utility_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/mac/video_capture_device_mac.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/api/dev/ppp_zoom_dev.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_zoom_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_case.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libusb/src/libusb/os/darwin_usb.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/bindings/npapi.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/npapi/bindings/npfunctions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/content_settings.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (11 generated)
tommycli
thestig: chrome/ PTAL piman: content/ PTAL cpu: other PTAL This is a (mostly) mechanical change ...
5 years, 9 months ago (2015-03-13 22:07:59 UTC) #2
Lei Zhang
On 2015/03/13 22:07:59, tommycli wrote: > thestig: chrome/ PTAL > piman: content/ PTAL > cpu: ...
5 years, 9 months ago (2015-03-13 22:27:19 UTC) #3
piman
LGTM for content/
5 years, 9 months ago (2015-03-13 22:48:55 UTC) #4
cpu_(ooo_6.6-7.5)
the doc_generated/ files, are they generated? secondly, lets not change /terms/ lets have another CL ...
5 years, 9 months ago (2015-03-14 02:24:00 UTC) #5
tommycli
On 2015/03/14 02:24:00, cpu wrote: > the doc_generated/ files, are they generated? > > secondly, ...
5 years, 9 months ago (2015-03-16 17:54:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007443004/40001
5 years, 9 months ago (2015-03-16 17:55:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49932)
5 years, 9 months ago (2015-03-16 18:46:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007443004/40001
5 years, 9 months ago (2015-03-16 18:53:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49971)
5 years, 9 months ago (2015-03-16 19:23:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007443004/40001
5 years, 9 months ago (2015-03-16 19:34:38 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49992)
5 years, 9 months ago (2015-03-16 20:04:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007443004/40001
5 years, 9 months ago (2015-03-16 20:14:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007443004/40001
5 years, 9 months ago (2015-03-16 20:14:50 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-16 20:16:54 UTC) #25
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 20:17:38 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e86b2982a90cc87afbeb8599cc54c274c482b0ec
Cr-Commit-Position: refs/heads/master@{#320782}

Powered by Google App Engine
This is Rietveld 408576698