Introduce StrategyOnCacheMiss enum instead of |cached_only| boolean.

Introduce StrategyOnCacheMiss enum instead of |cached_only|  boolean.

BUG=437865
Committed: https://crrev.com/458e06bfc5d3a9747f805e9a0488b02156990962
Cr-Commit-Position: refs/heads/master@{#320999}

[engedy, 2015-03-17 13:44:06]

engedy@chromium.org changed reviewers:
+ mkwst@chromium.org

[engedy, 2015-03-17 13:44:06]

Mike, as per https://codereview.chromium.org/947563002/, I have introduced an
enum instead a boolean for |cached_only|.

I would very much welcome suggestions with regard to the naming. In particular,
StrategyOnCacheMiss::FAIL does not sound like much of a strategy to me.

[Mike West, 2015-03-17 13:47:10]

LGTM.

https://codereview.chromium.org/1006813008/diff/1/components/password_manager...
File components/password_manager/core/browser/affiliation_service.h (right):

https://codereview.chromium.org/1006813008/diff/1/components/password_manager...
components/password_manager/core/browser/affiliation_service.h:97: enum class
StrategyOnCacheMiss { FETCH_OVER_NETWORK, FAIL };
These names seem fine to me. Failure is totally a strategy.

If you really want to change them, I'd suggest: `CacheDisposition { USE_CACHE,
DO_NOT_USE_CACHE }`, but I don't think that's so much better that you MUST MUST
MUST change it.

[engedy, 2015-03-17 13:54:07]

https://codereview.chromium.org/1006813008/diff/1/components/password_manager...
File components/password_manager/core/browser/affiliation_service.h (right):

https://codereview.chromium.org/1006813008/diff/1/components/password_manager...
components/password_manager/core/browser/affiliation_service.h:97: enum class
StrategyOnCacheMiss { FETCH_OVER_NETWORK, FAIL };
On 2015/03/17 13:47:10, Mike West wrote:
> These names seem fine to me. Failure is totally a strategy.
> 
> If you really want to change them, I'd suggest: `CacheDisposition { USE_CACHE,
> DO_NOT_USE_CACHE }`, but I don't think that's so much better that you MUST
MUST
> MUST change it.

I dwelled on it for a bit more, and while a bit weirder, StrategyOnCacheMiss
seems to convey more information.

[engedy, 2015-03-17 21:17:48]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2015-03-17 21:18:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1006813008/1

[commit-bot: I haz the power, 2015-03-17 22:33:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-17 22:33:58]

Patchset 1 (id:??) landed as
https://crrev.com/458e06bfc5d3a9747f805e9a0488b02156990962
Cr-Commit-Position: refs/heads/master@{#320999}