Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/password_manager/core/browser/affiliation_service_unittest.cc

Issue 1006813008: Introduce StrategyOnCacheMiss enum instead of |cached_only| boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aff_integ_final
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/affiliation_service_unittest.cc
diff --git a/components/password_manager/core/browser/affiliation_service_unittest.cc b/components/password_manager/core/browser/affiliation_service_unittest.cc
index 61764b82849c0322a98c18d99e79992f4399f17c..4a85811677f8f2127370d1f415172e0b4d74b77a 100644
--- a/components/password_manager/core/browser/affiliation_service_unittest.cc
+++ b/components/password_manager/core/browser/affiliation_service_unittest.cc
@@ -24,6 +24,8 @@ namespace password_manager {
namespace {
+using StrategyOnCacheMiss = AffiliationService::StrategyOnCacheMiss;
+
const char kTestFacetURIAlpha1[] = "https://one.alpha.example.com";
const char kTestFacetURIAlpha2[] = "https://two.alpha.example.com";
const char kTestFacetURIAlpha3[] = "https://three.alpha.example.com";
@@ -102,7 +104,7 @@ TEST_F(AffiliationServiceTest, GetAffiliations) {
// The first request allows on-demand fetching, and should trigger a fetch.
// Then, it should succeed after the fetch is complete.
service()->GetAffiliations(FacetURI::FromCanonicalSpec(kTestFacetURIAlpha1),
- false /* cached_only */,
+ StrategyOnCacheMiss::FETCH_OVER_NETWORK,
mock_consumer()->GetResultCallback());
background_task_runner()->RunUntilIdle();
@@ -115,7 +117,7 @@ TEST_F(AffiliationServiceTest, GetAffiliations) {
// The second request should be (and can be) served from cache.
service()->GetAffiliations(FacetURI::FromCanonicalSpec(kTestFacetURIAlpha1),
- true /* cached_only */,
+ StrategyOnCacheMiss::FAIL,
mock_consumer()->GetResultCallback());
background_task_runner()->RunUntilIdle();
@@ -128,7 +130,7 @@ TEST_F(AffiliationServiceTest, GetAffiliations) {
// The third request is also restricted to the cache, but cannot be served
// from cache, thus it should fail.
service()->GetAffiliations(FacetURI::FromCanonicalSpec(kTestFacetURIBeta1),
- true /* cached_only */,
+ StrategyOnCacheMiss::FAIL,
mock_consumer()->GetResultCallback());
background_task_runner()->RunUntilIdle();
@@ -141,7 +143,8 @@ TEST_F(AffiliationServiceTest, GetAffiliations) {
TEST_F(AffiliationServiceTest, ShutdownWhileTasksArePosted) {
service()->GetAffiliations(FacetURI::FromCanonicalSpec(kTestFacetURIAlpha1),
- false, mock_consumer()->GetResultCallback());
+ StrategyOnCacheMiss::FETCH_OVER_NETWORK,
+ mock_consumer()->GetResultCallback());
EXPECT_TRUE(background_task_runner()->HasPendingTask());
DestroyService();

Powered by Google App Engine
This is Rietveld 408576698