components/password_manager/core/browser/affiliated_match_helper.cc - Issue 1006813008: Introduce StrategyOnCacheMiss enum instead of |cached_only| boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliated_match_helper.cc

Issue 1006813008: Introduce StrategyOnCacheMiss enum instead of |cached_only| boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aff_integ_final

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/password_manager/core/browser/affiliated_match_helper_unittest.cc » ('j') | components/password_manager/core/browser/affiliation_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliated_match_helper.cc

diff --git a/components/password_manager/core/browser/affiliated_match_helper.cc b/components/password_manager/core/browser/affiliated_match_helper.cc

index 529eda4aa9f1d4bdce90fbd2318d5b0f3bc6a7c4..36a9e9786b3bc63e4fdbc77a07fea71d81ab5bc3 100644

--- a/components/password_manager/core/browser/affiliated_match_helper.cc

+++ b/components/password_manager/core/browser/affiliated_match_helper.cc

@@ -63,7 +63,7 @@ void AffiliatedMatchHelper::GetAffiliatedAndroidRealms(

if (observed_form.scheme == autofill::PasswordForm::SCHEME_HTML &&

observed_form.ssl_valid && facet_uri.IsValidWebFacetURI()) {

affiliation_service_->GetAffiliations(

- facet_uri, true /* cached_only */,

+ facet_uri, AffiliationService::StrategyOnCacheMiss::FAIL,

base::Bind(&AffiliatedMatchHelper::OnGetAffiliationsResults,

weak_ptr_factory_.GetWeakPtr(), facet_uri, result_callback));

} else {