Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: net/http/http_cache_transaction.cc

Issue 1006643002: Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a few more tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index a1974682368700bc4d84ec9bdca3d6243f6a939e..944590a740e4bbe6abcb60b9eaea502d11026ec2 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -694,6 +694,16 @@ int HttpCache::Transaction::ResumeNetworkStart() {
return ERR_UNEXPECTED;
}
+// TODO(ttuttle): Should the HttpCache::Transaction be accumulating these
+// instead of just proxying to the (current?) HttpNetworkTransaction?
Randy Smith (Not in Mondays) 2015/04/23 19:04:08 Put a little bit more detail into this TODO, maybe
Deprecated (see juliatuttle) 2015/04/23 21:04:16 Better yet, I'll just do it now.
+void HttpCache::Transaction::GetConnectionAttempts(
+ ConnectionAttempts* out) const {
+ if (network_trans_)
+ network_trans_->GetConnectionAttempts(out);
+ else
+ out->clear();
+}
+
//-----------------------------------------------------------------------------
void HttpCache::Transaction::DoCallback(int rv) {

Powered by Google App Engine
This is Rietveld 408576698