Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction.

net/http/http_cache_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_cache_transaction.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_POSIX)
 #include <unistd.h>
@@ skipping 676 matching lines @@
   DCHECK(!network_trans_);
   before_proxy_headers_sent_callback_ = callback;
 }
 
 int HttpCache::Transaction::ResumeNetworkStart() {
   if (network_trans_)
     return network_trans_->ResumeNetworkStart();
   return ERR_UNEXPECTED;
 }
 
+// TODO(ttuttle): Should the HttpCache::Transaction be accumulating these
+// instead of just proxying to the (current?) HttpNetworkTransaction?

[Randy Smith (Not in Mondays), 2015/04/23 19:04:08]

Put a little bit more detail into this TODO, maybe your current view of the
arguments for/against doing accumulation?  I'm worried that it's targeted at
someone with your current level of knowledge.  I wouldn't have a lot of clue
about how to go about executing this TODO if I were to take on that task.  I
suspect you'll be in the same position six months from now, and someone who
isn't one of us would be in substantially worse shape.

[Deprecated (see juliatuttle), 2015/04/23 21:04:16]

Better yet, I'll just do it now.

+void HttpCache::Transaction::GetConnectionAttempts(
+    ConnectionAttempts* out) const {
+  if (network_trans_)
+    network_trans_->GetConnectionAttempts(out);
+  else
+    out->clear();
+}
+
 //-----------------------------------------------------------------------------
 
 void HttpCache::Transaction::DoCallback(int rv) {
   DCHECK(rv != ERR_IO_PENDING);
   DCHECK(!callback_.is_null());
 
   read_buf_ = NULL;  // Release the buffer before invoking the callback.
 
   // Since Run may result in Read being called, clear callback_ up front.
   CompletionCallback c = callback_;
@@ skipping 2323 matching lines @@
     default:
       NOTREACHED();
   }
 }
 
 void HttpCache::Transaction::OnIOComplete(int result) {
   DoLoop(result);
 }
 
 }  // namespace net