Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction.

net/http/failing_http_transaction_factory.cc

Index: net/http/failing_http_transaction_factory.cc
diff --git a/net/http/failing_http_transaction_factory.cc b/net/http/failing_http_transaction_factory.cc
index a190597e369814f6d6a2635bcbd5e79b8dea23a1..b871576712411168c01eef857500a712ef96c82f 100644
--- a/net/http/failing_http_transaction_factory.cc
+++ b/net/http/failing_http_transaction_factory.cc
@@ -10,6 +10,7 @@
 #include "base/message_loop/message_loop.h"
 #include "net/base/load_timing_info.h"
 #include "net/base/upload_progress.h"
+#include "net/socket/connection_attempts.h"
 
 namespace net {
 
@@ -61,6 +62,7 @@ class FailingHttpTransaction : public HttpTransaction {
   void SetBeforeProxyHeadersSentCallback(
       const BeforeProxyHeadersSentCallback& callback) override;
   int ResumeNetworkStart() override;
+  void GetConnectionAttempts(ConnectionAttempts* out) const override;
 
  private:
   Error error_;
@@ -163,6 +165,11 @@ int FailingHttpTransaction::ResumeNetworkStart()  {
   return ERR_FAILED;
 }
 
+void FailingHttpTransaction::GetConnectionAttempts(
+    ConnectionAttempts* out) const {
+  NOTIMPLEMENTED();

[Randy Smith (Not in Mondays), 2015/04/23 19:04:08]

This seems like it would break any browser level tests using
FailingHttpTransaction, but if all try jobs pass, I'm good with it.

[Deprecated (see juliatuttle), 2015/04/23 21:04:16]

Yeah, I'd rather have it fail explicitly if we end up using it, so whoever uses
it can think about what they want it to return. (Presumably a failing
transaction may fail in the connection phase, in which case they'd want to add a
mock value.)

+}
+
 }  // namespace
 
 FailingHttpTransactionFactory::FailingHttpTransactionFactory(